
To support (un)erasing "V2" Ink shapes that were loaded from the PDF, there needs to be a PDFiumEngine::UpdateShapeActive() method, similar to how manipulating strokes require UpdateStrokeActive(). Add UpdateShapeActive(), along with tests. Though one part of it is disabled due to a crash in PDFium that requires investigating. As part of this, rename PDFiumEngineInkStrokesTest to PDFiumEngineInkDrawTest to better reflect what the test does. Bug: 353942910 Change-Id: I42ada29f9dc63634882748e5d77ba2c5fbab979a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6007521 Reviewed-by: Alan Screen <awscreen@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380790}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.