98f446ed62
This CL is adding a loop around the call to sqlite3_open_v2(...) for the case where the returned error code is kBusy. The kBusy error code is the most common ones received from our metrics. Since Chrome is not opening the file multiple times, it should never happened. We are assuming it's an interaction with third-party and are hoping that the retry loop will reduces the amount of failures. The metrics 'Sql.Database.Success.SqliteOpenRetries' is added to track whether or not this approach is working. Bug: 369635654 Change-Id: If83f5cbd98f81e6319b4f284c5d7c040fccd9644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6191568 Reviewed-by: Anthony Vallée-Dubois <anthonyvd@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/main@{#1410947}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.