
Deleting the context writes to the external pointer table and to the heap, hence we must enter the isolate before deleting the context. This is blocking a new DCHECK in v8: https://crrev.com/c/6387098 For consistency, we should also move the HandleScope from the `PerContextData` destructor to the `ShellRunner` destructor, but this causes failures in other users of `PerContextData`, so this is left for a follow-up CL. Drive-by cleanup: Remove `using` declarations which were mostly not used, and if they were then inconsistently. R=mlippautz@chromium.org Bug: 396607238 Change-Id: I110a72c047d3a719e9606fc98f32f2b0536bb656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6394240 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#1438234}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.