
I noticed that the CheckBreakingInstallerVersionBumpNeeded check was printing "No installer breaking changes detected" on presubmit --all runs and thought it was the common case of a presubmit that was never written to handle presubmit --all. That was not the case. The presubmit was actually broken in a few ways: 1) The path matching didn't work on Windows - fixed by normalizing to '/' path separators. 2) The use of the default FilterSourceFile filter meant that the chrome.release file never made it through. 3) The location of the PRESUBMIT.py file in chrome/installer meant that changes to chrome/test were never seen. So, the presubmit was moved from chrome/installer to chrome. 4) The combination of 2 and 3 meant that 'files' was always empty so the warning would trigger whenever the last_breaking_installer_version.cc file was touched. This change was tested various ways, including this way: git cl presubmit --force --files "chrome/test/mini_installer*;chrome/installer/setup/last_breaking_installer_version.cc" -v Bug: 1453842 Change-Id: I49d91499978c97237136913f5337a67f3d14121e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606364 Reviewed-by: S Ganesh <ganesh@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1156329}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.