c66e9c85b6
Context: -------- I was surprised @clamy was forced to use `DanglingUntriaged-notes` while moving a file. This is unexpected. Especially given this behavior was tested [0]. Root Cause: ----------- The root cause is a divergence in between the depot_tool implementation [1][2] using `include_deletes=False` and Chromes's mocks implementation [3][4] using `include_deletes=True`. The test was correctly written, but the environment not correctly simulated ;-( This patches reconcile the two. [0]: https://source.chromium.org/chromium/chromium/src/+/main:PRESUBMIT_test.py;l=5144-5167 [1]: https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:presubmit_support.py;l=810-817 [2]: https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:presubmit_support.py;l=1377?q=%22def%20AffectedSourceFiles%22%20-f:third_party [3]: https://source.chromium.org/chromium/chromium/src/+/main:PRESUBMIT_test_mocks.py;l=106-107 [4]: https://source.chromium.org/chromium/chromium/src/+/main:PRESUBMIT_test_mocks.py;l=273-275 Bug: chromium:1395297 Change-Id: I646adbe9e53dfe606bfcfacd41b4f794d49042be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447014 Reviewed-by: Dominic Battre <battre@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1291133}
v8
@ ee7fe2f6a1
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.