With the exception of ui/gfx/color_utils.h, code in //ui/gfx use
namespace gfx, so if "gfx::" does not appear in a header, then it does
not need the //ui/gfx includes. The command below generated the list of
edited files:
git grep -l '^#include "ui/gfx' components|grep '\.h$'|xargs grep -L gfx::
Clean up those headers and then do IWYU to fix the build.
Bug: 40318405
Change-Id: I89122602c3aa7d09ac1490b48297bf09366f01e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6558849
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1462366}
This changes our COMPONENT_EXPORT macros to make the things they export
visible all the time on non-windows, rather than making them visible in
the named component only. This avoids subtle bugs where things defined
in multiple components end up with one copy per component, only one of
which is visible, and so the linker doesn't know it's supposed to dedup
them.
Some, but not all, of these issues are detected by the new clang warning
-Wunique-object-duplication. This change addresses some instances of that
warning firing on chromium code, but not all. Conversely, there are likely
instances which the warning does not catch, which are fixed by this CL.
Bug: 368047728
Change-Id: I829a9bd84e57e3c7d80ec33aea0408951019bde7
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6264795
Owners-Override: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Devon Loehr <dloehr@google.com>
Cr-Commit-Position: refs/heads/main@{#1456614}
This CL is pure clean-up and contains no functionality changes.
Depending on the files covered in the CL (since the CL was generated
using git cl split), it does a subset of the following:
- Remove unneeded operator!= declarations/definitions since C++20 can
automatically derive those from operator==.
- Default operator== where this is equivalent to the current behavior.
- Default operator<=> where this is equivalent to the current
behavior.
This CL was uploaded by git cl split.
R=dljames@chromium.org
Bug: 40256175
Change-Id: If9c5a170ffb29dc20a4e78a8b97fd901451369eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6513635
Auto-Submit: Jan Keitel <jkeitel@google.com>
Reviewed-by: Darryl James <dljames@chromium.org>
Commit-Queue: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1456470}
Moves the general mock for sessions::TabRestoreService to the sessions
component for easier reuse by clients outside of components/commerce.
Bug: 406904337
Change-Id: Ifa33239283ed679769c35fa9c41e988383f35151
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6450341
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@google.com>
Cr-Commit-Position: refs/heads/main@{#1446480}
Updates the boolean parameter restored_from_group_or_window_context to
is_restoring_group_or_window which better reflects what it is capturing.
Adds an additional comment TabRestoreServiceHelper::RestoreTab which
describes what is_restoring_group_or_window does. This comment is
similar to the one that can be found in live_tab_context.h already.
Includes other small comment updates for clarity.
Change-Id: I7a048671e3d91f315b9fc60062367d687beedc10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409453
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1440476}
AddRestoredTab does not take into account the context for which we are
restoring a tab. This change makes it so we know if the tab being
restored is by itself, or restored alongside other tabs within its
group or window.
This change is necessary to prevent tab duplication for saved groups as
we want SavedTabGroups to be the source of truth for restored groups.
Tab duplication was happening anytime there was a conflict between the
SavedTabGroup and the tab group persisted in TabRestore.
Now we only rely on the SavedTabGroup if we have one.
Change-Id: I6266e63f281832341a2b2cdc96de727f20b22882
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6381720
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1438261}
Windows that are closed with a single tab are now represented as
window entries with a single tab in the recent tabs submenu.
This CL removes the logic from the service meaning other platforms
using it the service are not subject to desktop specific logic.
Removes SessionRestoreTest.WindowWithOneTab since it is no longer
applicable.
Updates remaining tests to account for this change.
Change-Id: I0168dbadfecd4e9b611b91989180e3900d40627b
Bug: 41227458, 40438075, 40846749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6387072
Reviewed-by: David Pennington <dpenning@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437715}
Some platforms support window-related session management at display
server side. Such as, Linux/Wayland with xdg-session-management protocol
extension. In that case, 1 new piece of data must be requested and
persisted by the client application in order to be able to ask the
windowing system to restore window states when needed:
- platform_session_id: a string that identifies a platform session,
generated by the display server (eg: the Wayland compositor
implementing the xdg-session-management protocol), stored by chromium
in the session commands backing storage, and sent back to the display
server when restoring a browser session.
Further design notes available at
https://notes.nickdiego.dev/chromium/wayland-session-management
The upcoming CLs will add the remaining bits, including:
- UI/Views framework API required additions.
- Ozone/Wayland implementation based on xdg-toplevel-drag-v1 protocol.
- Chrome required plumbing and required changes.
Bug: 352081012
Change-Id: I5d2d7c5755c1cf5848bffd6231cc75f3fda2def3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6329136
Reviewed-by: Darryl James <dljames@chromium.org>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1437661}
Pass the SessionId of the window or group to remove when they become
empty after a restore.
This prevents a bug where the recent tabs menu could show entries with
0 restorable tabs. See bug for screenshot.
Change-Id: I44c4364121d14061079df06cebd86db450531eaf
Bug: 405426765
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6382275
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436327}
When a window is created via TabRestore as the first tab restore
entry, the tabs in the window (and group) are not populated with
saved information if the browser had crashed or powered down in an
unclean state. This causes new groups to be created, even though they
should be mapped to saved groups.
This Cl adds methods that assign the correct saved information to the
tabs so they dont duplicate groups.
Fixed: 389107698
Change-Id: Ic6f387c533263def3102e35d013abf8c903feeee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6177194
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: David Pennington <dpenning@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1407984}
Upgrading myself to OWNER of this subdirectory since I have made quite
a few contributions in this area already and have an understanding of
the structure of this system and how it works.
Already an OWNER of chrome/browser/sessions/
Change-Id: I9f5047d0c888bc3c1297e326a2f0f3d42494f292
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6174068
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1407644}
NOTREACHED() and NOTREACHED_IN_MIGRATION() are both CHECK-fatal now.
The former is [[noreturn]] so this CL also performs dead-code removal
after the NOTREACHED().
This CL does not attempt to do additional rewrites of any surrounding
code, like:
if (!foo) {
NOTREACHED();
}
to CHECK(foo);
Those transforms take a non-trivial amount of time (and there are
thousands of instances). Cleanup can be left as an exercise for the
reader.
Bug: 40580068
Change-Id: I72205fb77747957c6bf33dbea93656fd20085a42
Low-Coverage-Reason: OTHER Should-be-unreachable code
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6010008
Reviewed-by: Rick Byers <rbyers@chromium.org>
Owners-Override: Rick Byers <rbyers@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1382618}
I need an owner's approval please for changes under:
['components/favicon', 'components/favicon_base', 'components/query_parser', 'components/sessions', 'components/visitedlink']
This is a mechanical change. There are a few instances (but not all)
of empty user-defined constructors and destructors which can be
defaulted in the /components code.
This CL was uploaded by git cl split.
R=sky@chromium.org
Bug: 371316188
Change-Id: If2b363c364d8437b6a65434bacc49a73a033152f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5918669
Auto-Submit: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1366386}
The crash happens when a grouped tab is restored into a browser that
does not support tab groups. In this scenario, we will touch multiple
different kinds of CHECKS / nullptr dereferences which will crash the
browser.
Changes:
- CHECK TabGroupModel, TabStripModel, and TabGroup have values before
use in BrowserLiveTabContext::SetVisualDataForGroup and
BrowserLiveTabContext::GetVisualDataForGroup
- Restore the grouped tab as an ungrouped tab if there is no
TabGroupModel for the browser
- Adds a regression test for this specific scenario
Change-Id: I0230b7a7c86c31c77740488ce8959de77bd20865
Bug: 368139715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5888488
Commit-Queue: Darryl James <dljames@chromium.org>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Reviewed-by: Steven Luong <stluong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1360585}
This CL removes `WindowShowState` enum from ui_base_types.h.
Replaces the uses of `WindowShowState` with the mojo version in
components folder.
Created an alias for previous style with mojom to be usable for now
in other places. When every instance is replaced, alias will be
removed.
`WindowShowState` is moved from ui_base_types.mojom to it's own
mojom due to circular dependency between `ui/base/mojom` and `ui/base`.
`WindowShowState` will be moved back to ui_base_types.mojom once
the circular dependency is gone.
A modified version of the following script is used for replacing
with different folder name.
Script: https://issues.chromium.org/issues/355460976#comment2
AX-Relnotes: N/A
Bug: 355460976
Change-Id: I92999c064fba2fd9d5a1619c49009785ca5ccb83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5793019
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Auto-Submit: Md Hasibul Hasan <hasibulhasan873@gmail.com>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1354297}
This includes the top ~30 in M128 and ~20 in M127 on ChromeOS.
... except the few ones I can't find due to ICF, or ones that have
already been fixed or removed as erroneous.
This is to further derisk NOTREACHED-fatal rollout. Per crash-reporting
volumes on Windows we should be about 1/50 as crashy as CHECK failures
after this has landed.
40264195, 40895492, 354661907, 363109548, 361609999, 352381196,
361612971, 362124606, 355803743, 41369768, 345232410, 346893376,
40910294
Bug: 40580068, 332263206, 40942310, 40948203, 355803743, 362506636,
Change-Id: I56e42b3b7c8ce17d6dabb5d7edb48db925240e34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5824114
Owners-Override: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1349061}
1. If a window with a single tab has a user supplied title,
when closing we shouldn't add the tab. Instead we should
add the window. Adding the tab means we lose the title.
2. SessionService::WindowOpened should set the user title.
Otherwise it won't be saved.
Bug: None
Test: None
Change-Id: Ia2bef8a6a655eeffe5f417f5366d2a29975d8ecf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5763166
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1338487}
TimeTicks should only be used to measure local duration (same machine,
same process) and not absolute time. TimeTicks may not increment during
process suspension (this is platform dependent) and so TimeTicks created
at different time do not share a common reference. As a consequence, it
is not possible to convert them to absolute times.
WebContents::LastActiveTime is intended to represent the date of the
last activation time, that will be persisted and sent to sync. Because
it uses TimeTicks, this field is incorrectly synced for WebContents
created on Mac or ChromeOS machines. Convert the field to a base::Time
to fix it.
Convert the field to a base::Time to fix it.
Bug: 349542284
Change-Id: Iba85b1579f8ee9ec22d60219c8f8f444eef3336d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5735384
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1338463}
The EnableSessionSerializationOptimizations feature has launched
and SessionRestorationServiceImpl is returned by the factory. It
requires to enable placeholder tabs support. The placeholder tab
support also work with LegacySessionRestorationService (it is
not required, but it works).
Thus clean IOSChromeSyncedTabDelegate to assumes placeholder tab
support is always enabled and remove dead code.
Bug: 40945317
Change-Id: Ia08205f56d5ee9ff02dac5dfc074a30cc9eeb2c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5746956
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1335420}
On other desktop platforms(linux, mac, chromeos,etc), when
user uses keyboard shortcut "ctrl-shift-t" to re-open the
most recently closed tab, after the tab is restored, it is
set as the current tab. On Clank, however, the restored tab
is inactive. This makes the user experience inconsistent
on clank. This cl fixes this issue by always setting the
tab(most recently closed) restored as the current tab.
This cl fixes the case for restoring a tab without snackbar
showing up, i.e. from tab restore service.
Bug: 348478081
Change-Id: I912143efb508a6ab4bec4cfd50e37eb3d6a964c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5669932
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1332509}
This CL addresses 4 different issues with enabling default save in V2,
1) Enabled default save of groups restored from session
2) Fixed to support asynchronous saving of groups at startup since
the model initialization might have not completed
3) Fixed an issue where session data wasn't restored correctly for the
saved GUID when there were multiple records in the append log
4) Tab Group session metadata was only updated when there was a change
in visual data. This led to cases where the saved GUID wasn't updated.
This was updated to listen for saved tab group model changes when groups
were saved or unsaved
Change-Id: I4d2255c11ad4022be701f0ee32115f5d8977ae6a
Bug: 344016224
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5608434
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: David Pennington <dpenning@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Commit-Queue: Eshwar Stalin <estalin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1313032}
This fixes a regression introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/5460410
TabRestoreServiceHelper is saving selected_tab_index in
TabRestoreServiceHelper::BrowserClosing() but the saved index wasn't
used later and TabRestoreServiceHelper was always activating the first
tab when the whole window was restored.
This CL adds a test TabRestoreTest.RestoreWindow_ActiveTabIndex that
verifies that the active tab is still active after closing and
restoring the window.
Bug: 344606398
Change-Id: I6c3262a465b8d902a4ba9a7213fdad6142a38723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5594032
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1311219}
This was generated by replacing " NOTREACHED()" with
" NOTREACHED_IN_MIGRATION()" and running git cl format.
This prepares for making NOTREACHED() [[noreturn]] alongside
NotReachedIsFatal migration of existing inventory.
Bug: 40580068
Change-Id: I92e83d0b564d44267f003147a1ce6ba3674621a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539175
Owners-Override: Lei Zhang <thestig@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1300923}
When the last session of a browser is loaded it does not take the traditional route of adding an entry into the TabRestoreService. Instead of going through the helper classes (TabRestoreServiceHelper, TabRestoerServiceImpl) which provide all of the setup for the tab_restore::Window object, loading the last sessions immediately adds the entry to the TabRestoreService.
This means that any fields that require pre-processing will be empty. To fix this, we add an additional check when a WINDOW entry is added to populate its tab_groups field. This ultimately prevents a CHECK crash that will happen when a user clicks on the 3-dot (app menu) button.
Change-Id: Ia27673d6f5a82cdbff6cbb84977daf84075ad8bf
Bug: 338555375
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5515918
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1296295}
Update the tab restore Tab and Group pickles to keep track of the saved group id. This must be done to prevent duplicating a saved group when we restore an entry after the browser has been restarted.
Change-Id: I90a6724e7890bb8a8b1502e95e5d2adb427f1f3b
Bug: 330769691, 330769723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5498867
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294912}
Adds the menu item "Restore group" and a separator to groups within a
window object. Previously it was not possible to restore an entire group
within a window. Users had to manually select each tab they wanted to
restore.
Instead they can click a single menu item!
Screencast available at crbug.com/331230893
Change-Id: I3310c5aa551305b1065211404d1efbe3277bc819
Bug: 331230893, 332721077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480409
Commit-Queue: Darryl James <dljames@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293917}
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: I8a9934c8837b7e99594af4d63d4343128b70f7fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493246
Auto-Submit: Alison Gale <agale@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293200}
Initial implementation for restoring SavedTabGroups and their tabs.
List of Changes:
- Ungrouped tabs will restore normally
- Restored tabs which are grouped will be restored normally then saved
- Restored groups will be restored normally and saved
- Restore saved groups will open the saved group and add any tabs that are not in the list of tabs already
- The first index of restored windows will be activated instead of the last index
- The first index of restored groups will be activated instead of the last index
Change-Id: I15c6a2f22b20cd2a01704d31286e253af05de16d
Bug: 335270082
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5460410
Commit-Queue: Darryl James <dljames@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291461}
Moves the tab restore structs Entry, Tab, Group, and Window out
of the TabRestoreService and into its own file.
The goal of this CL is to decouple LiveTabContext from
TabRestoreService, which includes LiveTabContext. Doing this will allow
us to pass the Tab, Group, and Window types as parameters to functions
such as LiveTabContext::AddRestoredTab instead of passing all the fields
of the objects individually.
Change-Id: I2f30bb25f934806112333d67ed3586dade09fe46
Bug: 334170377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5449978
Commit-Queue: Darryl James <dljames@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1288110}
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: I89f0a4d7ddeb7c9585f3a0e5421aef8ce5a6f0f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5455854
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1287738}
Implements the ability to restore windows with saved tab groups in their saved state when using the keyboard shortcut (ctrl+shift+t).
Does not implement the ability to restore windows with saved tab groups through the recent tabs submenu.
Change-Id: I0aa356c6aabf1b9957b05680572a3946561141f7
Bug: 330769406, 330769367, 333425400
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5411104
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284789}
