I had the issue that vscode didn't notice file changes e.g.
by git cl format. Excluding out/ and third_party/ with
files.watcherExclude seems to help.
Files per folder:
10934 v8
14436 native_client
17478 data
26470 build
37676 chrome
389528 third_party
426532 out
BUG=
Review-Url: https://codereview.chromium.org/2847723002
Cr-Commit-Position: refs/heads/master@{#467668}
The Windows build instructions mention that the 14393 SDK is needed but
now that 15063 has shipped the SDK is harder to find, leading some
developers to do problematic hacks. This adds a link to the archival
installer.
R=scottmg@chromium.org
Review-Url: https://codereview.chromium.org/2846643002
Cr-Commit-Position: refs/heads/master@{#467512}
This removes a mention to OnceCallback support of PostTask, since
PostTask does support OnceCallback now.
BUG=554299
Review-Url: https://codereview.chromium.org/2830223002
Cr-Commit-Position: refs/heads/master@{#466591}
To webview_instrumentation_apk and webview_instrumentation_test_apk
BUG=701938
Review-Url: https://codereview.chromium.org/2802093008
Cr-Commit-Position: refs/heads/master@{#466368}
This CL moves autoplay code from HTMLMediaElement to the
AutoplayPolicy class, which helps decoupling the autoplay logic
from HTMLMediaElement.
BUG=712606
Review-Url: https://codereview.chromium.org/2813303005
Cr-Commit-Position: refs/heads/master@{#466137}
Adding all sources to a "_all" pseudo module fixes Studio's code analysis
functions (imports, refactoring).
In order to have things build properly in gradle, the "_all" module has
all sources excluded (gradle applies the filters, studio does not).
Also fix "--all" targets to include tests. Make it easier to make sweeping
java refactors in Android Studio.
BUG=620034
Review-Url: https://codereview.chromium.org/2812133003
Cr-Commit-Position: refs/heads/master@{#465700}
Using the newly created bundleid and mobileprovision, the search widget
can be integrated in the application alongside the current today widget.
When running on device after this check-in, it is necessary to install
the SearchTodayExtension mobileprovision.
BUG=622743, 682230
Review-Url: https://codereview.chromium.org/2814783003
Cr-Commit-Position: refs/heads/master@{#465606}
Adds documentation about installation and usage of Visual
Studio Code as an editor for Chromium. The documentation
is to be referenced from the Chromium developers web page,
https://www.chromium.org/developers, as a sibling of Atom,
Sublime Text etc.
BUG=None
TEST=None
Review-Url: https://codereview.chromium.org/2710503003
Cr-Commit-Position: refs/heads/master@{#463964}
We have switched to a debian/jessie sysroot so
wheezy support is not longer needed.
BUG=697494
Review-Url: https://codereview.chromium.org/2597523003
Cr-Commit-Position: refs/heads/master@{#462181}
- The script setup-gn.py is not run as part of `gclient runhooks`
upstream, so update the documentation to not say the opposite.
- Fix an error in the setup-gn.py that treated any non-empty
value for FORCE_MAC_TOOLCHAIN environment variable as a `True`
(in python any non-empty string is `True` in a boolean context).
BUG=None
Review-Url: https://codereview.chromium.org/2804633002
Cr-Commit-Position: refs/heads/master@{#462065}
Support Clank development with the next version of Android Studio.
BUG=700438
Review-Url: https://codereview.chromium.org/2797703004
Cr-Commit-Position: refs/heads/master@{#462050}
It looks like most of the recently added model types have not been
adding their associated KeyedService dependencies to
*ProfileSyncServiceFactory. This change updates the dependencies to
include everything used by both *ProfileSyncServiceFactory and
*ChromeSyncClient, along with some alphabetization for the ios
DependOn()s.
Couldn't add a dependency to SupervisedUserServiceFactory because it
apparently already depends on ProfileSyncServiceFactory, so added TODOs
to fix this.
BUG=701326
Review-Url: https://codereview.chromium.org/2768923005
Cr-Commit-Position: refs/heads/master@{#460133}
This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
page_info*:
- chrome/browser/ui/page_info
- chrome/browser/ui/cocoa/page_info
- chrome/browser/ui/views/page_info
- chrome/browser/ui/android/page_info
- chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
guards.
- mass-rename.py does not handle test files (https://crbug.com/701529) or
Java, so those are handled separately, either in an early step are as part
of the later renames.
- `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments *WebsiteSettings* to *PageInfo* across the entire Chromium project.
- Since several content settings classes are also called "WebsiteSettings", this is done by taking a full list of all occurrences of full tokens containing "WebsiteSettings", "website_settings", or "website settings" and whitelisting individual replacements.
- To avoid modifying strings, all lines containing the relevant tokens *following at least one quote mark on the same line* are preserved, except two individually handled cases. There do not appear to be any affected multi-line strings.
- `git cl format`
- Remove two long-standing TODO comments about this rename, in:
- PageInfoPopup.java
- page_info_bubble_controller.h
This CL does not attempt to reflow comments; all changes stay within 80 lines, though.
[1] https://github.com/lgarron/website-settings-to-page-info/blob/master/page_info.fish
BUG=571506
TBR=jochen@chromium.org
Review-Url: https://codereview.chromium.org/2754383004
Cr-Commit-Position: refs/heads/master@{#459562}
WebView no longer supports the android_webview_apk target for anything
other than automated testing. Keeping docs for building an unsupported
target is misleading, especially since android_webview_apk is not
actually a WebView.
This CL keeps the description about WebView, but removes the parts
about the test shell. It has a pointer to our team's chromium wiki page
for building and installing AOSP WebView.
This renames the section to "Build WebView" instead of "Build WebView
shell" to reflect the update.
BUG=703376
Review-Url: https://codereview.chromium.org/2770983007
Cr-Commit-Position: refs/heads/master@{#459221}
Now that 2.3 has been released, it will be the default version downloaded
by developers. //build/android/gradle/generate_gradle.py doesn't work
with 2.3 yet, and this should be reflected in our docs (we only support
2.2 currently).
BUG=700438
Review-Url: https://codereview.chromium.org/2758053002
Cr-Commit-Position: refs/heads/master@{#458060}
Added the method to callback.md because it's helpful yet I hadn't discovered it (callback_helpers.h is a more obscure file than callback.h or bind_helpers.h)
BUG=none
R=tzik@chromium.org
Review-Url: https://codereview.chromium.org/2755073002
Cr-Commit-Position: refs/heads/master@{#457939}
Reason for revert:
Breaks code editing in Android Studio, see http://crbug/700438 for more info.
Original issue's description:
> Android: Support Android Studio 2.3
>
> Also fixes excludes filters not working. For files whose directory is
> not fully included in the target, add those individually instead.
>
> BUG=700438
>
> Review-Url: https://codereview.chromium.org/2746103004
> Cr-Commit-Position: refs/heads/master@{#457093}
> Committed: f9fca7ca02TBR=wnwen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=700438
Review-Url: https://codereview.chromium.org/2758683003
Cr-Commit-Position: refs/heads/master@{#457866}
Also fixes excludes filters not working. For files whose directory is
not fully included in the target, add those individually instead.
BUG=700438
Review-Url: https://codereview.chromium.org/2746103004
Cr-Commit-Position: refs/heads/master@{#457093}
Fixes the original example, which resulted in an invalid conversion from
base::OnceCallback<void(int)> to base::Closure. Also adds a comment that
this usage is not yet supported.
BUG=none
R=tzik@chromium.org
Review-Url: https://codereview.chromium.org/2735903002
Cr-Commit-Position: refs/heads/master@{#456886}
The docs still need to be updated with more detailed instructions and
tips, but currently the docs don't even mention debugging in Android
Studio.
BUG=620034
Review-Url: https://codereview.chromium.org/2740353003
Cr-Commit-Position: refs/heads/master@{#456185}
This CL replaces the Clang 'c++-analyzer' Perl script with logic added to the Python wrapper script. This gives us the hooks we need to run analysis builds with "gomacc" (necessary for distributed builds) and gives us a convenient place to specify analyzer config flags which aren't exposed by scan-build.
Adds a warning suppression rule which prevents the analyzer from raising false positives from stdlib code (code w/namespace "std").
Other changes:
* Modify Goma portions of the GCC toolchain GNI to build paths to
the Clang static analyzer.
* Create an exception for ASM tool invocations, which don't play
well with the analysis command line flags.
* Removed 'scan-build' DEP.
BUG=687245
R=thakis@chromium.org,wez@chromium.org
Review-Url: https://codereview.chromium.org/2667853004
Cr-Commit-Position: refs/heads/master@{#456136}
This solves 2 problems:
1. Regenerating MANIFEST.json is failing on ToT (bug 697207)
- Now that MANIFEST.json is in .gitignore, regeneration works
2. Regenerating adds MANIFEST.json to MANIFEST.json (bug 683485)
- MANIFEST.json no longer shows up in MANIFEST.json
BUG=697207,666957,683485
Change-Id: I09987b66027e1f94055888c8ead58e7e40896d62
Reviewed-on: https://chromium-review.googlesource.com/447959
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#454454}
